[RELEASE CANDIDATE] Apache-Test-1.31 RC2

[Fred Moyer]

Greetings,

Please, download, test, and report back on success or failure for this
Apache::Test release candidate.

Development from 1.30 has been ongoing for about two years, so this is
as good a time as ever to make a release.

http://people.apache.org/~phred/Apache-Test-1.31-rc2.tar.gz

This candidate resolves an issue with httpd binaries that were
compiled without mod_version, and also adds a fix for the following RT
ticket:

https://rt.cpan.org/Ticket/History.html?id=21554

[Adam Prime]

Passes all tests on 2.2.10 w/ mp 2.0.4 and perl 5.8.8 on linux (ubuntu
hardy).

Passes all tests on 2.2.14 w/ mp 2.0.4 and perl 5.8.8 on solaris 5.10

I tried to run it against our (extremely old) 1.3 setup at work, but i'm
getting weird errors from httpd when i start it up:

Ouch! ap_mm_create(1048576, "/var/httpd/httpd.mm.2591") failed
Error: MM: mm:core: failed to open semaphore file (Permission denied):
OS: No such file or directory

Not sure what that's about, but i think it has more to do with works
weird setup than anything else.

I'll try to remember to run this against some more combinations later
tonight.

Adam

Post by Fred Moyer
Greetings,
Please, download, test, and report back on success or failure for this
Apache::Test release candidate.
Development from 1.30 has been ongoing for about two years, so this is
as good a time as ever to make a release.
http://people.apache.org/~phred/Apache-Test-1.31-rc2.tar.gz
This candidate resolves an issue with httpd binaries that were
compiled without mod_version, and also adds a fix for the following RT
https://rt.cpan.org/Ticket/History.html?id=21554
---------------------------------------------------------------------

[Fred Moyer]

I'll take that as a +1? :)

+1 from me, so that makes 2. Would like to get at least two more +1s
from mod_perl devs.

Thanks to everyone else who has taken a few minutes to test out this version.

Post by Adam Prime
Passes all tests on 2.2.10 w/ mp 2.0.4 and perl 5.8.8 on linux (ubuntu
hardy).
Passes all tests on 2.2.14 w/ mp 2.0.4 and perl 5.8.8 on solaris 5.10
I tried to run it against our (extremely old) 1.3 setup at work, but i'm
Ouch! ap_mm_create(1048576, "/var/httpd/httpd.mm.2591") failed
No such file or directory
Not sure what that's about, but i think it has more to do with works weird
setup than anything else.
I'll try to remember to run this against some more combinations later
tonight.
Adam

Post by Fred Moyer
Greetings,
Please, download, test, and report back on success or failure for this
Apache::Test release candidate.
Development from 1.30 has been ongoing for about two years, so this is
as good a time as ever to make a release.
http://people.apache.org/~phred/Apache-Test-1.31-rc2.tar.gz
This candidate resolves an issue with httpd binaries that were
compiled without mod_version, and also adds a fix for the following RT
https://rt.cpan.org/Ticket/History.html?id=21554
---------------------------------------------------------------------

---------------------------------------------------------------------

[David Dick]

Post by Fred Moyer
Please, download, test, and report back on success or failure for this
Apache::Test release candidate.

Passes all tests on 2.2.13 w/ mp 2.0.4 and perl 5.10 on linux (fedora 11)
Passes all tests on 2.2.9 w/ mp 2.0.4 and perl 5.10 on linux (debian lenny)

[Philippe M. Chiasson]

Post by Fred Moyer
Greetings,
Please, download, test, and report back on success or failure for this
Apache::Test release candidate.
Development from 1.30 has been ongoing for about two years, so this is
as good a time as ever to make a release.
http://people.apache.org/~phred/Apache-Test-1.31-rc2.tar.gz

Passes all tests on OSX/10.6 Apache/2.2.13/prefork mod_perl/2.0.4
Perl/v5.10.0

One small nit, not sure why, but t/next_available_port.t was modified
and will only be run if mod_cgi *and* mod_cgid is installed, which is
not very likely. Shouldn't this be what it does instead ?

diff -rdu Apache-Test-1.31-rc2/t/next_available_port.t
Apache-Test-1.31-rc2.test/t/next_available_port.t
--- Apache-Test-1.31-rc2/t/next_available_port.t 2009-04-18
05:59:26.000000000 -0400
+++ Apache-Test-1.31-rc2.test/t/next_available_port.t 2010-02-09
21:20:26.000000000 -0500
@@ -7,8 +7,7 @@
use Apache::TestRequest;
use Apache::TestUtil;

-plan tests => 1, need need_module('mod_cgi.c'),
- need_module('mod_cgid.c'),
+plan tests => 1, need need_cgi,
need_module('mod_env.c');

my $url = '/cgi-bin/next_available_port.pl';


Looking at Changes, I can see

"Use need_module('mod_cgi.c') and need_module('mod_cgid.c') in
t/next_available_port.t instead of need_cgi. On case insensitive file
systems such as OS X, need_cgi will fulfill the requirement with cgi.pm,
when mod_cgi.c is the desired requirement.
[Fred Moyer <***@apache.org>]"

Wouldn't the correct solution be to fix need_cgi then :

diff -ru Apache-Test-1.31-rc2.test/blib/lib/Apache/Test.pm
Apache-Test-1.31-rc2/blib/lib/Apache/Test.pm
--- Apache-Test-1.31-rc2.test/blib/lib/Apache/Test.pm 2010-02-09
13:21:39.000000000 -0500
+++ Apache-Test-1.31-rc2/blib/lib/Apache/Test.pm 2010-02-09
21:27:47.000000000 -0500
@@ -348,7 +348,7 @@
}

sub need_cgi {
- return _need_multi(qw(cgi cgid));
+ return _need_multi(qw(cgi.c cgid.c));
}

[Fred Moyer]

On Tue, Feb 9, 2010 at 6:40 PM, Philippe M. Chiasson

Post by Philippe M. Chiasson
One small nit, not sure why, but t/next_available_port.t was modified
and will only be run if mod_cgi *and* mod_cgid is installed, which is
not very likely. Shouldn't this be what it does instead ?
diff -rdu Apache-Test-1.31-rc2/t/next_available_port.t
Apache-Test-1.31-rc2.test/t/next_available_port.t
--- Apache-Test-1.31-rc2/t/next_available_port.t        2009-04-18
05:59:26.000000000 -0400
+++ Apache-Test-1.31-rc2.test/t/next_available_port.t   2010-02-09
21:20:26.000000000 -0500
@@ -7,8 +7,7 @@
 use Apache::TestRequest;
 use Apache::TestUtil;
-plan tests => 1, need need_module('mod_cgi.c'),
-                 need_module('mod_cgid.c'),
+plan tests => 1, need need_cgi,
                 need_module('mod_env.c');

Yes, thanks for the spot there. Applied.

Post by Philippe M. Chiasson
Looking at Changes, I can see
"Use need_module('mod_cgi.c') and need_module('mod_cgid.c') in
t/next_available_port.t instead of need_cgi.  On case insensitive file
systems such as OS X, need_cgi will fulfill the requirement with cgi.pm,
when mod_cgi.c is the desired requirement.
diff -ru Apache-Test-1.31-rc2.test/blib/lib/Apache/Test.pm
Apache-Test-1.31-rc2/blib/lib/Apache/Test.pm
--- Apache-Test-1.31-rc2.test/blib/lib/Apache/Test.pm   2010-02-09
13:21:39.000000000 -0500
+++ Apache-Test-1.31-rc2/blib/lib/Apache/Test.pm        2010-02-09
21:27:47.000000000 -0500
@@ -348,7 +348,7 @@
 }
 sub need_cgi {
-    return _need_multi(qw(cgi cgid));
+    return _need_multi(qw(cgi.c cgid.c));
 }

Ah, this is a much better approach. I don't think I completely
understood that _need_multi was OR instead of AND last time I looked
at it.

Both changes applied r909744. Thanks Philippe!